fix(camera): Android dialog not fully showing when in landscape #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: If state isn't set to STATE_EXPANDED, the BottomSheet will open collapsed when orientation is landscape. References: https://outsystemsrd.atlassian.net/browse/RMET-3826
Context: `instanceof` already returns `false if `behavior` is null References: https://outsystemsrd.atlassian.net/browse/RMET-3826
|
Released dev build of camera with dev version: 7.0.0-dev-2276-20241210T153000.0 |
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
...ra/android/src/main/java/com/capacitorjs/plugins/camera/CameraBottomSheetDialogFragment.java
Outdated
Show resolved
Hide resolved
OS-ricardomoreirasilva
approved these changes
Dec 10, 2024
IT-MikeS
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CameraSheetDialogFragmentthat wasn't fully showing when orientation was landscape, by explicitly setting its state toBottomSheetBehavior.STATE_EXPANDED.instanceofwill returnfalseifbehavioris null.Closes: #2224